chore(release): 4.14.0-dev.12 [skip ci]

# [4.14.0-dev.12](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.11...v4.14.0-dev.12) (2024-09-14) ### Bug Fixes * **Soundcloud - Hide ads:** Support latest version ([#3628](https://github.com/ReVanced/revanced-patches/issues/3628)) ([2f7d751](2f7d751f9f))
fix(Soundcloud - Hide ads): Support latest version (#3628 )
2025-12-26 02:44:08 +01:00 · 2024-09-14 15:09:54 +00:00 · 2024-09-14 17:07:27 +02:00 · 2024-09-12 20:11:21 +00:00 · 2024-09-12 22:09:09 +02:00 · 2024-09-12 18:30:19 +00:00
16 changed files with 152 additions and 19 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,31 @@
+# [4.14.0-dev.12](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.11...v4.14.0-dev.12) (2024-09-14)
+
+
+### Bug Fixes
+
+* **Soundcloud - Hide ads:** Support latest version ([#3628](https://github.com/ReVanced/revanced-patches/issues/3628)) ([66e7e33](https://github.com/ReVanced/revanced-patches/commit/66e7e33efce9b702fdfcc2b9803e9da8491c1f08))
+
+# [4.14.0-dev.11](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.10...v4.14.0-dev.11) (2024-09-12)
+
+
+### Features
+
+* **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](https://github.com/ReVanced/revanced-patches/commit/98ead493380932cb105530f4ba992673fd364d82))
+
+# [4.14.0-dev.10](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.9...v4.14.0-dev.10) (2024-09-12)
+
+
+### Features
+
+* **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](https://github.com/ReVanced/revanced-patches/commit/46d11f3530fcdae9ed08b7e93aac235638a92dff))
+
+# [4.14.0-dev.9](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.8...v4.14.0-dev.9) (2024-09-09)
+
+
+### Features
+
+* **YouTube:** Add donation link to settings about screen ([#3626](https://github.com/ReVanced/revanced-patches/issues/3626)) ([0684ab5](https://github.com/ReVanced/revanced-patches/commit/0684ab5f183631de5720352049cfd293daa58eb0))
+
 # [4.14.0-dev.8](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.7...v4.14.0-dev.8) (2024-09-09)


--- a/api/revanced-patches.api
+++ b/api/revanced-patches.api
@@ -828,6 +828,12 @@ public final class app/revanced/patches/reddit/customclients/syncforreddit/fix/s
 	public static final field INSTANCE Lapp/revanced/patches/reddit/customclients/syncforreddit/fix/slink/FixSLinksPatch;
 }

+public final class app/revanced/patches/reddit/customclients/syncforreddit/fix/user/UseUserEndpointPatch : app/revanced/patcher/patch/BytecodePatch {
+	public static final field INSTANCE Lapp/revanced/patches/reddit/customclients/syncforreddit/fix/user/UseUserEndpointPatch;
+	public fun execute (Lapp/revanced/patcher/data/BytecodeContext;)V
+	public synthetic fun execute (Lapp/revanced/patcher/data/Context;)V
+}
+
 public final class app/revanced/patches/reddit/customclients/syncforreddit/misc/integrations/IntegrationsPatch : app/revanced/patches/shared/misc/integrations/BaseIntegrationsPatch {
 	public static final field INSTANCE Lapp/revanced/patches/reddit/customclients/syncforreddit/misc/integrations/IntegrationsPatch;
 }
--- a/gradle.properties
+++ b/gradle.properties
@@ -1,4 +1,4 @@
 org.gradle.parallel = true
 org.gradle.caching = true
 kotlin.code.style = official
-version = 4.14.0-dev.8
+version = 4.14.0-dev.12
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/UseUserEndpointPatch.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/UseUserEndpointPatch.kt
@@ -0,0 +1,61 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user
+
+import app.revanced.patcher.data.BytecodeContext
+import app.revanced.patcher.extensions.InstructionExtensions.getInstruction
+import app.revanced.patcher.extensions.InstructionExtensions.replaceInstruction
+import app.revanced.patcher.fingerprint.MethodFingerprint
+import app.revanced.patcher.patch.BytecodePatch
+import app.revanced.patcher.patch.annotation.CompatiblePackage
+import app.revanced.patcher.patch.annotation.Patch
+import app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints.*
+import app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints.OAuthFriendRequestFingerprint
+import app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints.OAuthSubredditInfoRequestHelperFingerprint
+import app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints.OAuthUnfriendRequestFingerprint
+import app.revanced.util.getReference
+import app.revanced.util.resultOrThrow
+import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction
+import com.android.tools.smali.dexlib2.iface.reference.StringReference
+
+@Patch(
+    name = "Use /user/ endpoint",
+    description = "Replaces the deprecated endpoint for viewing user profiles /u with /user, that used to fix a bug.",
+    compatiblePackages = [
+        CompatiblePackage("com.laurencedawson.reddit_sync"),
+        CompatiblePackage("com.laurencedawson.reddit_sync.pro"),
+        CompatiblePackage("com.laurencedawson.reddit_sync.dev"),
+    ],
+    use = false,
+)
+@Suppress("unused")
+object UseUserEndpointPatch : BytecodePatch(
+    fingerprints = setOf(
+        OAuthFriendRequestFingerprint,
+        OAuthSubredditInfoRequestConstructorFingerprint,
+        OAuthSubredditInfoRequestHelperFingerprint,
+        OAuthUnfriendRequestFingerprint,
+        OAuthUserIdRequestFingerprint,
+        OAuthUserInfoRequestFingerprint,
+    ),
+) {
+    override fun execute(context: BytecodeContext) {
+        arrayOf(
+            OAuthFriendRequestFingerprint,
+            OAuthSubredditInfoRequestConstructorFingerprint,
+            OAuthSubredditInfoRequestHelperFingerprint,
+            OAuthUnfriendRequestFingerprint,
+            OAuthUserIdRequestFingerprint,
+            OAuthUserInfoRequestFingerprint,
+        ).map(MethodFingerprint::resultOrThrow).map {
+            it.scanResult.stringsScanResult!!.matches.first().index to it.mutableMethod
+        }.forEach { (userPathStringIndex, method) ->
+            val userPathStringInstruction = method.getInstruction<OneRegisterInstruction>(userPathStringIndex)
+            val userPathStringRegister = userPathStringInstruction.registerA
+            val fixedUserPathString = userPathStringInstruction.getReference<StringReference>()!!.string.replace("u/", "user/")
+
+            method.replaceInstruction(
+                userPathStringIndex,
+                "const-string v$userPathStringRegister, \"${fixedUserPathString}\"",
+            )
+        }
+    }
+}
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/BaseUserEndpointFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/BaseUserEndpointFingerprint.kt
@@ -0,0 +1,10 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints
+
+import app.revanced.patcher.fingerprint.MethodFingerprint
+
+internal abstract class BaseUserEndpointFingerprint(source: String, accessFlags: Int? = null) :
+    MethodFingerprint(
+        accessFlags = accessFlags,
+        strings = listOf("u/"),
+        customFingerprint = { _, classDef -> classDef.sourceFile == source },
+    )
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthFriendRequestFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthFriendRequestFingerprint.kt
@@ -0,0 +1,3 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints
+
+internal object OAuthFriendRequestFingerprint : BaseUserEndpointFingerprint("OAuthFriendRequest.java")
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthSubredditInfoRequestConstructorFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthSubredditInfoRequestConstructorFingerprint.kt
@@ -0,0 +1,10 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints
+
+import app.revanced.patcher.extensions.or
+import com.android.tools.smali.dexlib2.AccessFlags
+
+internal object OAuthSubredditInfoRequestConstructorFingerprint :
+    BaseUserEndpointFingerprint(
+        "OAuthSubredditInfoRequest.java",
+        AccessFlags.PUBLIC or AccessFlags.CONSTRUCTOR,
+    )
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthSubredditInfoRequestHelperFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthSubredditInfoRequestHelperFingerprint.kt
@@ -0,0 +1,10 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints
+
+import app.revanced.patcher.extensions.or
+import com.android.tools.smali.dexlib2.AccessFlags
+
+internal object OAuthSubredditInfoRequestHelperFingerprint :
+    BaseUserEndpointFingerprint(
+        "OAuthSubredditInfoRequest.java",
+        AccessFlags.PRIVATE or AccessFlags.STATIC,
+    )
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthUnfriendRequestFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthUnfriendRequestFingerprint.kt
@@ -0,0 +1,3 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints
+
+internal object OAuthUnfriendRequestFingerprint : BaseUserEndpointFingerprint("OAuthUnfriendRequest.java")
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthUserIdRequestFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthUserIdRequestFingerprint.kt
@@ -0,0 +1,3 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints
+
+internal object OAuthUserIdRequestFingerprint : BaseUserEndpointFingerprint("OAuthUserIdRequest.java")
--- a/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthUserInfoRequestFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/reddit/customclients/syncforreddit/fix/user/fingerprints/OAuthUserInfoRequestFingerprint.kt
@@ -0,0 +1,3 @@
+package app.revanced.patches.reddit.customclients.syncforreddit.fix.user.fingerprints
+
+internal object OAuthUserInfoRequestFingerprint : BaseUserEndpointFingerprint("OAuthUserInfoRequest.java")
--- a/src/main/kotlin/app/revanced/patches/soundcloud/ad/HideAdsPatch.kt
+++ b/src/main/kotlin/app/revanced/patches/soundcloud/ad/HideAdsPatch.kt
@@ -62,7 +62,7 @@ object HideAdsPatch : BytecodePatch(

        // Prevent verification of an HTTP header containing the user's current plan, which would contradict the previous patch.
        InterceptFingerprint.resultOrThrow().let { result ->
-            val conditionIndex = result.scanResult.patternScanResult!!.endIndex
+            val conditionIndex = result.scanResult.patternScanResult!!.endIndex + 1
            result.mutableMethod.addInstruction(
                conditionIndex,
                "return-object p1",
--- a/src/main/kotlin/app/revanced/patches/soundcloud/ad/fingerprints/InterceptFingerprint.kt
+++ b/src/main/kotlin/app/revanced/patches/soundcloud/ad/fingerprints/InterceptFingerprint.kt
@@ -9,14 +9,13 @@ internal object InterceptFingerprint : MethodFingerprint(
    accessFlags = AccessFlags.PUBLIC.value,
    parameters = listOf("L"),
    opcodes = listOf(
-        Opcode.INVOKE_INTERFACE,
        Opcode.MOVE_RESULT_OBJECT,
-        Opcode.INVOKE_VIRTUAL,
-        Opcode.MOVE_RESULT,
-        Opcode.IF_EQZ,
+        Opcode.INVOKE_INTERFACE,
+        Opcode.MOVE_RESULT_OBJECT
    ),
    strings = listOf("SC-Mob-UserPlan", "Configuration"),
    customFingerprint = { _, classDef ->
-        classDef.sourceFile == "ApiUserPlanInterceptor.java"
+        classDef.sourceFile == "ApiUserPlanInterceptor.java" ||
+        classDef.sourceFile == "ApiUserPlanInterceptor.kt"
    },
 )
--- a/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsResourcePatch.kt
+++ b/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsResourcePatch.kt
@@ -28,8 +28,6 @@ object SettingsResourcePatch : BaseSettingsResourcePatch(
    override fun execute(context: ResourceContext) {
        super.execute(context)

-        AddResourcesPatch(this::class)
-
        // Used for a fingerprint from SettingsPatch.
        appearanceStringId = ResourceMappingPatch["string", "app_theme_appearance_dark"]

--- a/src/main/resources/addresources/values/strings.xml
+++ b/src/main/resources/addresources/values/strings.xml
@@ -53,6 +53,14 @@ This is because Crowdin requires temporarily flattening this file and removing t
            <string name="revanced_settings_import_reset">ReVanced settings reset to default</string>
            <string name="revanced_settings_import_success">Imported %d settings</string>
            <string name="revanced_settings_import_failure_parse">Import failed: %s</string>
+            <string name="revanced_pref_import_export_title">Import / Export</string>
+            <string name="revanced_pref_import_export_summary">Import / Export ReVanced settings</string>
+            <!-- Settings about dialog. -->
+            <string name="revanced_settings_about_links_body">You are using ReVanced Patches version &lt;i>%s&lt;/i></string>
+            <string name="revanced_settings_about_links_dev_header">Note</string>
+            <string name="revanced_settings_about_links_dev_body">This version is a pre-release and you may experience unexpected issues</string>
+            <string name="revanced_settings_about_links_header">Official links</string>
+            <string name="revanced_settings_about_links_donate">Donate</string>
        </patch>
        <patch id="misc.gms.BaseGmsCoreSupportResourcePatch">
            <!-- Translations of this should not be longer than the original English text, otherwise the text can be clipped and not entirely shown. -->
@@ -65,15 +73,6 @@ This is because Crowdin requires temporarily flattening this file and removing t
        </patch>
    </app>
    <app id="youtube">
-        <patch id="misc.settings.SettingsResourcePatch">
-            <string name="revanced_settings">ReVanced</string>
-            <string name="revanced_settings_about_links_body">You are using ReVanced Patches version &lt;i>%s&lt;/i></string>
-            <string name="revanced_settings_about_links_dev_header">Note</string>
-            <string name="revanced_settings_about_links_dev_body">This version is a pre-release and you may experience unexpected issues</string>
-            <string name="revanced_settings_about_links_header">Official links</string>
-            <string name="revanced_pref_import_export_title">Import / Export</string>
-            <string name="revanced_pref_import_export_summary">Import / Export ReVanced settings</string>
-        </patch>
        <patch id="misc.settings.SettingsPatch">
            <string name="revanced_settings_screen_00_about_title">About</string>
            <string name="revanced_settings_screen_01_ads_title">Ads</string>
--- a/src/main/resources/settings/layout/revanced_settings_with_toolbar.xml
+++ b/src/main/resources/settings/layout/revanced_settings_with_toolbar.xml
@@ -21,7 +21,7 @@
                android:layout_height="?attr/actionBarSize"
                android:background="?attr/ytBrandBackgroundSolid"
                app:navigationIcon="@drawable/yt_outline_arrow_left_black_24"
-                app:title="@string/revanced_settings" />
+                app:title="@string/revanced_settings_title" />
        </FrameLayout>

        <FrameLayout
Author	SHA1	Message	Date
semantic-release-bot	887684e7c7	chore(release): 4.14.0-dev.12 [skip ci] # [4.14.0-dev.12](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.11...v4.14.0-dev.12) (2024-09-14) ### Bug Fixes * Soundcloud - Hide ads: Support latest version ([#3628](https://github.com/ReVanced/revanced-patches/issues/3628)) ([`2f7d751`](`2f7d751f9f`))	2024-09-14 15:09:54 +00:00
FullerBread2032	2f7d751f9f	fix(Soundcloud - Hide ads): Support latest version (#3628 ) Co-authored-by: FullerBread2032 <admin@fullerbread2032.tk>	2024-09-14 17:07:27 +02:00
semantic-release-bot	4886a95713	chore(release): 4.14.0-dev.11 [skip ci] # [4.14.0-dev.11](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.10...v4.14.0-dev.11) (2024-09-12) ### Features * Sync for Reddit: Rename patch to `Use /user/ endpoint` ([`5871923`](`58719239cf`))	2024-09-12 20:11:21 +00:00
oSumAtrIX	58719239cf	feat(Sync for Reddit): Rename patch to `Use /user/ endpoint` The bug it was used to fix does not occur anymore. This name is more correct on what the patch actually does.	2024-09-12 22:09:09 +02:00
semantic-release-bot	fcb68cc65e	chore(release): 4.14.0-dev.10 [skip ci] # [4.14.0-dev.10](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.9...v4.14.0-dev.10) (2024-09-12) ### Features * Sync for Reddit: Add `Fix /user/ endpoint` patch ([`16217f0`](`16217f012e`))	2024-09-12 18:30:19 +00:00
oSumAtrIX	16217f012e	feat(Sync for Reddit): Add `Fix /user/ endpoint` patch	2024-09-12 20:18:22 +02:00
semantic-release-bot	d6f20ee67d	chore(release): 4.14.0-dev.9 [skip ci] # [4.14.0-dev.9](https://github.com/ReVanced/revanced-patches/compare/v4.14.0-dev.8...v4.14.0-dev.9) (2024-09-09) ### Features * YouTube: Add donation link to settings about screen ([#3626](https://github.com/ReVanced/revanced-patches/issues/3626)) ([`bccd62e`](`bccd62e593`))	2024-09-09 07:23:22 +00:00
LisoUseInAIKyrios	bccd62e593	feat(YouTube): Add donation link to settings about screen (#3626 )	2024-09-09 03:21:22 -04:00